Uh oh!
There was an error while loading. Please reload this page.
Conversation
tswast
commented
Oct 13, 2021
Do you want to add a nox session for this? |
tseaver
left a comment
There was a problem hiding this comment.
Shouldn't we be adding a mypy nox session?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
crwilcox
commented
Oct 14, 2021
This can merge, but bug should have a comment added that we want to evaluate mypy against google and tests (comment in code) This PR needs to merge to remove a class of errors from generated code https://www.github.com/googleapis/gapic-generator-python/issues/1026 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Remove '_CLIENT_INFO' from module scope.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
tseaver
commented
Oct 14, 2021
@googlebot I consent |
tseaver
commented
Oct 14, 2021
@googlebot I consent. |
crwilcox
commented
Oct 14, 2021
Seems a small coverage gap |
tseaver
commented
Oct 14, 2021
65a472b closes that gap. |
related to #447
For bigtable, specifying a subfolder fails, but package works fine. Ignoring for now