Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

chore: ensure mypy passes - #448

Merged
crwilcox merged 27 commits into
mainfrom
mypy
Oct 14, 2021
Merged

chore: ensure mypy passes#448
crwilcox merged 27 commits into
mainfrom
mypy

Conversation

@crwilcox

@crwilcoxcrwilcox commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

related to #447

mypy -p google.cloud.bigtable --no-incremental
Success: no issues found in 17 source files

For bigtable, specifying a subfolder fails, but package works fine. Ignoring for now

❯ ./.nox/unit-3-10/bin/mypy google/cloud/bigtable
google/cloud/bigtable/__init__.py: error: Source file found twice under different module names: "cloud.bigtable.client" and "google.cloud.bigtable.client"
Found 1 error in 1 file (errors prevented further checking)

@crwilcox
crwilcox requested review from a teamOctober 13, 2021 18:13
@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Oct 13, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
@tswast

Copy link
Copy Markdown
Contributor

Do you want to add a nox session for this?

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be adding a mypy nox session?

Comment threadgoogle/cloud/bigtable/__init__.py
Comment threadgoogle/cloud/bigtable/client.py Outdated
Comment threadgoogle/cloud/bigtable/client.py Outdated
Comment threadgoogle/cloud/bigtable/client.py Outdated
Comment threadgoogle/cloud/bigtable/table.py
@crwilcox

Copy link
Copy Markdown
ContributorAuthor

This can merge, but bug should have a comment added that we want to evaluate mypy against google and tests (comment in code)

This PR needs to merge to remove a class of errors from generated code https://www.github.com/googleapis/gapic-generator-python/issues/1026

@crwilcoxcrwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2021
Comment threadgoogle/cloud/bigtable/table.py Outdated
Comment threadgoogle/cloud/bigtable/table.py
Remove '_CLIENT_INFO' from module scope.
@google-cla

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-clagoogle-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 14, 2021
@tseaver

Copy link
Copy Markdown
Contributor

@googlebot I consent

@google-clagoogle-claBot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 14, 2021
@tseaver

Copy link
Copy Markdown
Contributor

@googlebot I consent.

@crwilcox

Copy link
Copy Markdown
ContributorAuthor

Seems a small coverage gap

google/cloud/bigtable/table.py 283 0 80 1 99% 64->63

@tseaver

Copy link
Copy Markdown
Contributor

65a472b closes that gap.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@crwilcox@tswast@tseaver@yoshi-kokoro