Uh oh!
There was an error while loading. Please reload this page.
tests: harden instance admin samples against timeouts - #452
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| # Get the instance created | ||
| instanceadmin.run_instance_operations(PROJECT, INSTANCE, CLUSTER1) | ||
| capsys.readouterr() # throw away output | ||
| # This won't work, because the instance isn't created yet |
There was a problem hiding this comment.
This comment took a bit to understand. Are you saying we can't add a cluster because INSTANCE doesn't exist (and you ensured that in the line above)?
"get the instance created" also feels weird. Are we getting the instance or creating it? I had similar feelings about those above. I recognize those were carried forward.
There was a problem hiding this comment.
The instance creation gets moved down to line 138 here -- the instance does not exist at the point that we first call instanceadmin.add_cluster.
The diff display is weird -- I don't get why it breaks up. All this PR does is move the "ensure the instance is set up" code inside a nested function (and therefore indented), wrapped in a backoff.
2952d25 to
1acba53Compare
Closes#383.
Closes#434.