Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

chore: use gapic-generator-python 0.58.0 - #480

Closed
gcf-owl-bot[bot] wants to merge 2 commits into
mainfrom
owl-bot-794060b3-516c-4ce7-a37f-88b260341f9e
Closed

chore: use gapic-generator-python 0.58.0#480
gcf-owl-bot[bot] wants to merge 2 commits into
mainfrom
owl-bot-794060b3-516c-4ce7-a37f-88b260341f9e

Conversation

@gcf-owl-bot

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

fix: fix resource path args for paths with =**

committer: parthea
PiperOrigin-RevId: 415036187

Source-Link: googleapis/googleapis@7f2f0d8

Source-Link: https://github.com/googleapis/googleapis-gen/commit/6d74d63528e8f44fa00f017cd8e326bcdfbfccc3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmQ3NGQ2MzUyOGU4ZjQ0ZmEwMGYwMTdjZDhlMzI2YmNkZmJmY2NjMyJ9

fix: fix resource path args for paths with =**
committer: parthea
PiperOrigin-RevId: 415036187
Source-Link: googleapis/googleapis@7f2f0d8
Source-Link: googleapis/googleapis-gen@6d74d63
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmQ3NGQ2MzUyOGU4ZjQ0ZmEwMGYwMTdjZDhlMzI2YmNkZmJmY2NjMyJ9
@gcf-owl-bot
gcf-owl-botBot requested review from a teamDecember 8, 2021 22:47
@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Dec 8, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 8, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2021

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parts of this PR which are not spurious imports are duplicating PR #475.

from .types.bigtable_instance_admin import ListInstancesRequest
from .types.bigtable_instance_admin import ListInstancesResponse
from .types.bigtable_instance_admin import PartialUpdateClusterMetadata
from .types.bigtable_instance_admin import PartialUpdateClusterRequest

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicates PR #475,


import grpc
from grpc.experimental import aio
import json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding imports seems pointless (and lint-breaking) without also adding code which uses them.


import grpc
from grpc.experimental import aio
import json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding imports seems pointless (and lint-breaking) without also adding code which uses them.


import grpc
from grpc.experimental import aio
import json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding imports seems pointless (and lint-breaking) without also adding code which uses them.

@tseavertseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 8, 2021
@partheaparthea closed this Dec 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.kokoro:force-runAdd this label to force Kokoro to re-run the tests.owl-bot-copy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tseaver@parthea