Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

chore(samples): Fixed a typo in the readme - #760

Merged
Mariatta merged 3 commits into
googleapis:mainfrom
shweta345:readme-typo
Apr 5, 2023
Merged

chore(samples): Fixed a typo in the readme#760
Mariatta merged 3 commits into
googleapis:mainfrom
shweta345:readme-typo

Conversation

@shweta345

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shweta345
shweta345 requested a review from a team as a code ownerMarch 31, 2023 03:42
@shweta345
shweta345 requested review from a team and rsamborskiMarch 31, 2023 03:42
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Mar 31, 2023
@dandhleedandhlee changed the title docs: Fixed a typo in the readmechore(samples): Fixed a typo in the readmeMar 31, 2023
dandhlee
dandhlee previously approved these changes Mar 31, 2023

@dandhleedandhlee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dandhleedandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 31, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 31, 2023
@shweta345shweta345 mentioned this pull request Mar 31, 2023
4 tasks
@dandhlee
dandhlee self-requested a review March 31, 2023 04:37
@dandhlee
dandhlee dismissed their stale reviewMarch 31, 2023 04:38

Commit message does not align

@dandhlee

Copy link
Copy Markdown
Contributor

Ah. This has the same issue as #758.

On the commit message, it should just say chore rather than docs, as docs triggers a new release and sample updates don't need one.

Could you amend the commit message and push again? Don't need to create a new branch and a new PR, but if that helps then that works too.

@shweta345

Copy link
Copy Markdown
ContributorAuthor

@dandhlee Noted. I edited the message. Can you let me know if it amended properly?

@dandhlee

Copy link
Copy Markdown
Contributor

Can you amend and push? I still see it as docs: https://github.com/googleapis/python-bigtable/pull/760/commits

@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Mar 31, 2023
@MariattaMariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2023
@Mariatta
Mariatta merged commit efe332c into googleapis:mainApr 5, 2023
Mariatta pushed a commit that referenced this pull request Apr 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.samplesIssues that are directly related to samples.size: xsPull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shweta345@dandhlee@Mariatta@yoshi-kokoro