Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

fix: pass kwargs through in 'from_service_account_json' - #109

Merged
tseaver merged 2 commits into
masterfrom
108-project-arg-to-from_service_account_json
Jun 25, 2021
Merged

fix: pass kwargs through in 'from_service_account_json'#109
tseaver merged 2 commits into
masterfrom
108-project-arg-to-from_service_account_json

Conversation

@tseaver

@tseavertseaver commented Jun 24, 2021

Copy link
Copy Markdown
Contributor

Also, pin 'googleapis-common-protos' for Python 2.7 tests.

Closes#108.

@tseaver
fix: pass kwargs through in 'from_service_account_json'
6fd373b
Also, pin 'googleapis-common-protos' for Python 2.7 tests.
Closes#108.
@tseaver
tseaver requested review from a team and busunkim96June 24, 2021 17:18
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2021
@tseavertseaver mentioned this pull request Jun 24, 2021
Closed
busunkim96
busunkim96 approved these changes Jun 24, 2021
View reviewed changes

@busunkim96busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

chrisrossi
chrisrossi suggested changes Jun 24, 2021
View reviewed changes
Comment threadgoogle/cloud/client.py Outdated
@tseaver
tseaver requested a review from chrisrossiJune 24, 2021 22:29
chrisrossi
chrisrossi approved these changes Jun 25, 2021
View reviewed changes

@chrisrossichrisrossi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tseaver
tseaver merged commit efc4bbf into masterJun 25, 2021
@tseaver
tseaver deleted the 108-project-arg-to-from_service_account_json branch June 25, 2021 14:40
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@chrisrossichrisrossichrisrossi approved these changes
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

project kwarg ignored when from_service_account_json is used

3 participants

@tseaver@chrisrossi@busunkim96