Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

feat: adding samples for default values - #64

Merged
m-strzelczyk merged 9 commits into
masterfrom
samples-default-values
Jun 29, 2021
Merged

feat: adding samples for default values#64
m-strzelczyk merged 9 commits into
masterfrom
samples-default-values

Conversation

@m-strzelczyk

@m-strzelczykm-strzelczyk commented Jun 15, 2021

Copy link
Copy Markdown
Contributor

Featuring the usage report API.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) -- not yet

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2021
@snippet-bot

snippet-botBot commented Jun 15, 2021•
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelBot added api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Jun 15, 2021
@m-strzelczykm-strzelczyk changed the title feat: adding samples for default values.feat: adding samples for default valuesJun 15, 2021
rsamborski
rsamborski reviewed Jun 16, 2021
View reviewed changes
Comment threadsamples/snippets/sample_default_values.py Outdated
rsamborski
rsamborski reviewed Jun 16, 2021
View reviewed changes
Comment threadsamples/snippets/sample_default_values.py Outdated
rsamborski
rsamborski reviewed Jun 16, 2021
View reviewed changes
Comment threadsamples/snippets/sample_default_values.py Outdated
@m-strzelczyk
feat: adding samples for default values
a36d7d6
Featuring the usage report API.
@m-strzelczyk
m-strzelczykforce-pushed the samples-default-values branch from 7254b68 to 4b372f9CompareJune 17, 2021 14:18
@m-strzelczyk
m-strzelczykforce-pushed the samples-default-values branch from 4b372f9 to 1b9ef96CompareJune 17, 2021 14:19
@m-strzelczyk
m-strzelczykforce-pushed the samples-default-values branch from d7f6d09 to 7e66749CompareJune 22, 2021 13:39
@m-strzelczyk
m-strzelczykforce-pushed the samples-default-values branch from 3a9a8b4 to a977b36CompareJune 28, 2021 11:49
@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2021
@m-strzelczyk
m-strzelczyk marked this pull request as ready for review June 29, 2021 10:50
@m-strzelczyk
m-strzelczyk requested a review from a team as a code ownerJune 29, 2021 10:50
busunkim96
busunkim96 suggested changes Jun 29, 2021
View reviewed changes
Comment threadsamples/snippets/sample_default_values.py Outdated
Comment threadsamples/snippets/sample_default_values.py Outdated
Comment threadsamples/snippets/sample_default_values.py Outdated
@m-strzelczyk
m-strzelczyk merged commit 553e389 into masterJun 29, 2021
@m-strzelczyk
m-strzelczyk deleted the samples-default-values branch June 29, 2021 19:44
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jul 27, 2021
@release-please
chore: release 0.4.2 (#86)
4706ef4
🤖 I have created a release \*beep\* \*boop\*
---
### [0.4.2](https://www.github.com/googleapis/python-compute/compare/v0.4.1...v0.4.2) (2021-07-26)
### Bug Fixes
* **deps:** pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x versions ([#81](https://www.github.com/googleapis/python-compute/issues/81)) ([1163f2b](https://www.github.com/googleapis/python-compute/commit/1163f2bb15f0e042bdd9562a31ad2ac7f39e3536))
### Documentation
* samples docstring and comments update ([#69](https://www.github.com/googleapis/python-compute/issues/69)) ([2d53eb1](https://www.github.com/googleapis/python-compute/commit/2d53eb1839a8751945ba7cdf12991f2970893df2))
* adding samples for default values ([#64](https://www.github.com/googleapis/python-compute/issues/64)) ([553e389](https://www.github.com/googleapis/python-compute/commit/553e3891179c2719a57d398ffc26c1459945bf4d))
### Miscellaneous Chores
* release as 0.4.2 ([#84](https://www.github.com/googleapis/python-compute/issues/84)) ([dc77c0c](https://www.github.com/googleapis/python-compute/commit/dc77c0c55eef9cc1c2e515137fe66b4d4afca77e))
* Kokoro uses separate project for concurent tests. ([#83](https://www.github.com/googleapis/python-compute/issues/83)) ([40afb33](https://www.github.com/googleapis/python-compute/commit/40afb333a963717853f70410a7a08eda5492418c))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-pleaserelease-pleaseBot mentioned this pull request Jan 13, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@rsamborskirsamborskirsamborski left review comments
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: computeIssues related to the googleapis/python-compute API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m-strzelczyk@rsamborski@busunkim96@yoshi-kokoro