Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

docs: samples docstring and comments update - #69

Merged
dinagraves merged 7 commits into
masterfrom
samples
Jul 2, 2021
Merged

docs: samples docstring and comments update#69
dinagraves merged 7 commits into
masterfrom
samples

Conversation

@m-strzelczyk

@m-strzelczykm-strzelczyk commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-labelproduct-auto-labelBot added the api: compute Issues related to the googleapis/python-compute API. label Jun 21, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
@m-strzelczyk
docs: Updating sample docstrings and comments
fd49cd3
Applying some changes after consulting with tech writer.
@m-strzelczykm-strzelczyk changed the title Samples docstring and comments update.Samples docstring and comments updateJun 22, 2021
@m-strzelczykm-strzelczyk changed the title Samples docstring and comments updatedocs: samples docstring and comments updateJun 22, 2021
@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Jun 23, 2021
@m-strzelczyk
m-strzelczyk marked this pull request as ready for review June 24, 2021 11:36
@m-strzelczyk
m-strzelczyk requested a review from a team as a code ownerJune 24, 2021 11:36
@m-strzelczyk

m-strzelczyk commented Jun 29, 2021

Copy link
Copy Markdown
ContributorAuthor

@dinagraves Can you please have a look? Those changes are only to the docstrings and comments.

@dinagraves
dinagraves merged commit 2d53eb1 into masterJul 2, 2021
@dinagraves
dinagraves deleted the samples branch July 2, 2021 18:08
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jul 27, 2021
@release-please
chore: release 0.4.2 (#86)
4706ef4
🤖 I have created a release \*beep\* \*boop\*
---
### [0.4.2](https://www.github.com/googleapis/python-compute/compare/v0.4.1...v0.4.2) (2021-07-26)
### Bug Fixes
* **deps:** pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x versions ([#81](https://www.github.com/googleapis/python-compute/issues/81)) ([1163f2b](https://www.github.com/googleapis/python-compute/commit/1163f2bb15f0e042bdd9562a31ad2ac7f39e3536))
### Documentation
* samples docstring and comments update ([#69](https://www.github.com/googleapis/python-compute/issues/69)) ([2d53eb1](https://www.github.com/googleapis/python-compute/commit/2d53eb1839a8751945ba7cdf12991f2970893df2))
* adding samples for default values ([#64](https://www.github.com/googleapis/python-compute/issues/64)) ([553e389](https://www.github.com/googleapis/python-compute/commit/553e3891179c2719a57d398ffc26c1459945bf4d))
### Miscellaneous Chores
* release as 0.4.2 ([#84](https://www.github.com/googleapis/python-compute/issues/84)) ([dc77c0c](https://www.github.com/googleapis/python-compute/commit/dc77c0c55eef9cc1c2e515137fe66b4d4afca77e))
* Kokoro uses separate project for concurent tests. ([#83](https://www.github.com/googleapis/python-compute/issues/83)) ([40afb33](https://www.github.com/googleapis/python-compute/commit/40afb333a963717853f70410a7a08eda5492418c))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@dinagravesdinagravesdinagraves approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: computeIssues related to the googleapis/python-compute API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m-strzelczyk@dinagraves