Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

feat: update to the latest version of the code generator - #147

Merged
gcf-merge-on-green[bot] merged 23 commits into
mainfrom
use-the-latest-python-code-generator
Nov 16, 2021
Merged

feat: update to the latest version of the code generator#147
gcf-merge-on-green[bot] merged 23 commits into
mainfrom
use-the-latest-python-code-generator

Conversation

@parthea

@partheaparthea commented Nov 9, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

The compute protos are now available in googleapis/googleapis, and the generated code is also available in googleapis/googleapis-gen here. This PR pulls in the latest version of the generated client from googleapis-gen, which may have significant differences. I've added the do not merge label while we discuss whether any differences could break user code.

This PR also deletes synth.py and adds configuration files for owl bot. owl bot will save time for maintainers as it will automatically open PRs when there are updates in googleapis-gen without requiring maintainers to run synthtool to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are updates to templated files.

fix(deps): require google-api-core >=2.2.0
fix(deps): require proto-plus >=1.19.7
docs: list oneofs in docstring
fix: add 'dict' annotation type to 'request'
feat: support self-signed JWT flow for service accounts
chore(samples): Merging usage bucket tests into one, to avoid race conditions

@partheaparthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 9, 2021
@partheaparthea self-assigned this Nov 9, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2021
@product-auto-labelproduct-auto-labelBot added the api: compute Issues related to the googleapis/python-compute API. label Nov 9, 2021
@parthea

parthea commented Nov 10, 2021

Copy link
Copy Markdown
ContributorAuthor

Blocked by googleapis/google-cloud-python#10566

@partheaparthea added the status: blocked Resolving the issue is dependent on other work. label Nov 10, 2021
@partheaparthea mentioned this pull request Nov 10, 2021
Closed
@busunkim96

busunkim96 commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

@parthea I chatted about this with @vam-google over chat. This library is relatively new and still in preview, so I think it's reasonable to ask folks to use a newer version of google-api-core to use it (even if it requires bumping versions of other libraries they are using together)

The alternative is back-porting quite a few significant changes to the v1 branch of google-api-core library, which I would prefer not to do at this point.

@partheaparthea removed the status: blocked Resolving the issue is dependent on other work. label Nov 10, 2021
parthea
parthea commented Nov 11, 2021
View reviewed changes
Comment threadgoogle/cloud/compute_v1/services/accelerator_types/transports/rest.py
@partheaparthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2021
@parthea
parthea marked this pull request as ready for review November 11, 2021 00:24
@parthea
parthea requested review from a teamNovember 11, 2021 00:24
@partheaparthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 11, 2021
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 11, 2021
@m-strzelczyk

m-strzelczyk commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

Those tests that are failing need to be somehow refactored, as they keep failing despite the fact that we use the 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT' setting.

Do you think turning the two tests that live in test_sample_default_values.py could stop those failures?

@m-strzelczyk

m-strzelczyk commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

Seems like merging the two tests did the trick :)

@partheaparthea added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. automerge Merge the pull request once unit tests and other checks pass. labels Nov 12, 2021
@partheaparthea assigned busunkim96 and unassigned partheaNov 12, 2021
@parthea

parthea commented Nov 12, 2021

Copy link
Copy Markdown
ContributorAuthor

@busunkim96 This is ready for review

busunkim96
busunkim96 reviewed Nov 12, 2021
View reviewed changes
Comment threadgoogle/cloud/compute_v1/types/compute_small.py Outdated
Comment threadowlbot.py
Comment threadgoogle/cloud/compute_v1/services/accelerator_types/transports/rest.py
Comment threadsamples/snippets/sample_default_values.py Outdated
@parthea

parthea commented Nov 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@busunkim96 Please could you take another look?

@parthea

parthea commented Nov 16, 2021

Copy link
Copy Markdown
ContributorAuthor

This is ready for review

@partheaparthea added the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit de739a1 into mainNov 16, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the use-the-latest-python-code-generator branch November 16, 2021 16:38
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2021
gcf-merge-on-greenBot pushed a commit that referenced this pull request Nov 16, 2021
@release-please
chore: release 0.8.0 (#153)
2075d7d
🤖 I have created a release \*beep\* \*boop\*
---
## [0.8.0](https://www.github.com/googleapis/python-compute/compare/v0.7.0...v0.8.0) (2021-11-16)
### Features
* support self-signed JWT flow for service accounts ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d))
* update to the latest version of the code generator ([#147](https://www.github.com/googleapis/python-compute/issues/147)) ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d))
### Bug Fixes
* add 'dict' annotation type to 'request' ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d))
* **deps:** require google-api-core >=2.2.0 ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d))
* **deps:** require proto-plus >=1.19.7 ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d))
### Documentation
* list oneofs in docstring ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@tpdownestpdownes mentioned this pull request Nov 16, 2021
Merged
3 tasks
@vam-googlevam-google mentioned this pull request Nov 22, 2021
Closed
@partheaparthea mentioned this pull request Jan 4, 2022
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Jan 13, 2022
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@m-strzelczykm-strzelczykAwaiting requested review from m-strzelczyk
@nicainnicainAwaiting requested review from nicainnicain was automatically assigned from googleapis/python-samples-owners
1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@busunkim96busunkim96

Labels

api: computeIssues related to the googleapis/python-compute API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@parthea@busunkim96@vam-google@m-strzelczyk@yoshi-kokoro