Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

feat: adding samples to start/stop/reset operations - #75

Merged
m-strzelczyk merged 13 commits into
masterfrom
samples-start-stop
Aug 4, 2021
Merged

feat: adding samples to start/stop/reset operations#75
m-strzelczyk merged 13 commits into
masterfrom
samples-start-stop

Conversation

@m-strzelczyk

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

b/192839790

Will be added to this page

@snippet-bot

snippet-botBot commented Jul 12, 2021

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-labelproduct-auto-labelBot added api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Jul 12, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2021
@m-strzelczykm-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2021
@m-strzelczyk
m-strzelczyk marked this pull request as ready for review July 20, 2021 08:52
@m-strzelczyk
m-strzelczyk requested a review from a team as a code ownerJuly 20, 2021 08:52
@m-strzelczykm-strzelczyk added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021
@m-strzelczykm-strzelczyk added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021
@m-strzelczyk
m-strzelczyk requested review from a teamJuly 22, 2021 13:51
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021
@m-strzelczykm-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2021
@m-strzelczykm-strzelczyk added the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
@gcf-merge-on-green

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
@m-strzelczyk

Copy link
Copy Markdown
ContributorAuthor

@engelke can you have a look?

@m-strzelczykm-strzelczyk added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2021
@m-strzelczyk

Copy link
Copy Markdown
ContributorAuthor

The tests should be finally fixed now. @engelke can you review?

@engelkeengelke left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadsamples/snippets/test_sample_default_values.py
@m-strzelczyk
m-strzelczyk merged commit 0df87a9 into masterAug 4, 2021
@m-strzelczyk
m-strzelczyk deleted the samples-start-stop branch August 4, 2021 10:14
@partheaparthea mentioned this pull request Aug 4, 2021
@release-pleaserelease-pleaseBot mentioned this pull request Jan 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: computeIssues related to the googleapis/python-compute API.cla: yesThis human has signed the Contributor License Agreement.kokoro:runAdd this label to force Kokoro to re-run the tests.samplesIssues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@m-strzelczyk@engelke@yoshi-kokoro@parthea