Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

docs(samples): Adding pagination sample. - #78

Merged
FrodoTheTrue merged 22 commits into
masterfrom
compute-pagination
Aug 10, 2021
Merged

docs(samples): Adding pagination sample.#78
FrodoTheTrue merged 22 commits into
masterfrom
compute-pagination

Conversation

@m-strzelczyk

Copy link
Copy Markdown
Contributor

Adding samples to demonstrate how pagination works in this library.

@product-auto-labelproduct-auto-labelBot added api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Jul 15, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2021
@snippet-bot

snippet-botBot commented Jul 19, 2021

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@m-strzelczyk

m-strzelczyk commented Jul 19, 2021

Copy link
Copy Markdown
ContributorAuthor

This tests will work once #79 is resolved. Waiting on #80

@m-strzelczyk
m-strzelczyk marked this pull request as ready for review July 19, 2021 15:05
@m-strzelczyk
m-strzelczyk requested a review from a team as a code ownerJuly 19, 2021 15:05
Comment threadsamples/snippets/quickstart.py Outdated
Comment threadsamples/snippets/quickstart.py Outdated
Comment threadsamples/snippets/quickstart.py Outdated
Comment threadsamples/snippets/sample_pagination.py Outdated
Comment threadsamples/snippets/sample_pagination.py Outdated
Comment threadsamples/snippets/sample_pagination.py Outdated
Comment threadsamples/snippets/sample_pagination.py
Comment threadsamples/snippets/sample_pagination.py Outdated
@m-strzelczyk
m-strzelczyk requested a review from a teamJuly 23, 2021 11:23
@m-strzelczyk
m-strzelczyk requested a review from a teamJuly 23, 2021 11:23
@m-strzelczykm-strzelczyk added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jul 23, 2021
@m-strzelczyk

Copy link
Copy Markdown
ContributorAuthor

@leahecole could you have a look?

@parthea

Copy link
Copy Markdown
Contributor

@m-strzelczyk, I see that a delay was added here possibly for working with eventual consistency. I hit a similar issue In python-monitoring and I added a retry to reduce the flakiness.

@m-strzelczyk

Copy link
Copy Markdown
ContributorAuthor

@m-strzelczyk, I see that a delay was added here possibly for working with eventual consistency. I hit a similar issue In python-monitoring and I added a retry to reduce the flakiness.

Thanks, I'll see how to apply this to those tests, they are really irritating :P

@m-strzelczykm-strzelczyk added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2021
@m-strzelczyk

Copy link
Copy Markdown
ContributorAuthor

OK, the sleeps seem to have solved the problem with those tests. @leahecole can you review?

@partheaparthea changed the title feat: Adding pagination sample.docs(samples): Adding pagination sample.Aug 4, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 4, 2021
@m-strzelczyk

Copy link
Copy Markdown
ContributorAuthor

@parthea can you perhaps give a review? I'd love to get this merged this week :P

Comment threadsamples/snippets/sample_pagination.py Outdated
Comment threadsamples/snippets/sample_pagination.py Outdated
Comment threadsamples/snippets/quickstart.py Outdated
Comment threadsamples/snippets/test_sample_pagination.py
Comment threadsamples/snippets/quickstart.py
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
Comment threadsamples/snippets/quickstart.py
Comment threadsamples/snippets/test_sample_pagination.py
@FrodoTheTrue
FrodoTheTrue merged commit db0404c into masterAug 10, 2021
@FrodoTheTrue
FrodoTheTrue deleted the compute-pagination branch August 10, 2021 17:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: computeIssues related to the googleapis/python-compute API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@m-strzelczyk@parthea@Xmasreturns@dandhlee@FrodoTheTrue@yoshi-kokoro