Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

fix: Update CI to use GitHub actions and build for osx, windows, linux - #51

Merged
crwilcox merged 10 commits into
googleapis:masterfrom
crwilcox:add-gh-actions
Jan 13, 2021
Merged

fix: Update CI to use GitHub actions and build for osx, windows, linux#51
crwilcox merged 10 commits into
googleapis:masterfrom
crwilcox:add-gh-actions

Conversation

@crwilcox

@crwilcoxcrwilcox commented Jan 12, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR

  1. fixes an issue in DLL discovery for 3.8, 3.9 on windows
  2. configures github actions for releasing new wheels
  3. removes kokoro based presubmit, continuous, release runs that are now covered here.

@crwilcox
crwilcox requested a review from a teamJanuary 12, 2021 22:35
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
andrewsg
andrewsg suggested changes Jan 12, 2021
View reviewed changes
Comment threadsrc/google_crc32c/__config__.py Outdated
Comment threadtests/conftest.py Outdated
@crwilcox

crwilcox commented Jan 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Will add separate commits to remove some of the old CI that this replaces

@crwilcoxcrwilcox changed the title fix: Update CI to use GitHub actions and build for osx, windows, linuxfix: Update CI to use GitHub actions and build for osx, windows, linuxJan 12, 2021
@crwilcox

crwilcox commented Jan 12, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This action won't run until merge, I have a followup PR to update the readme a bit for this project.

image

andrewsg
andrewsg approved these changes Jan 12, 2021
View reviewed changes

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the caveat that I don't understand the yaml file requirements so if it's hand-crafted I can't review its correctness. Thanks for this work!

@crwilcox

crwilcox commented Jan 13, 2021

Copy link
Copy Markdown
ContributorAuthor

@andrewsg I did run these with different triggers on my fork so I expect they work as expected 👍

@crwilcox
crwilcox merged commit 66f49b8 into googleapis:masterJan 13, 2021
@crwilcox
crwilcox deleted the add-gh-actions branch January 13, 2021 07:10
@partheaparthea mentioned this pull request Mar 11, 2024
Closed
vishwarajanand added a commit that referenced this pull request May 15, 2024
@vishwarajanand
Revert "fix: Update CI to use GitHub actions and build for osx, windo…
9873c73
…ws, linux (#51)"
This reverts commit 66f49b8.
@partheaparthea mentioned this pull request Aug 24, 2024
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@andrewsgandrewsgandrewsg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crwilcox@andrewsg