Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 2, 2026. It is now read-only.
fix: client-side path validation for batch.update - #1021
Merged
Conversation
danieljbruce
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _LEADING_ALPHA_INVALID check is too broad, triggering for more characters than the ones reported in the docstring. This is causing downstream issues, like preventing unquoted references to uuid fields. This PR reduces the scope of the validation, to check only against the invalid characters mentioned in the
FieldPath.from_stringdocstringFixes#1012