Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

fix: remove setup.cfg configuration for creating universal wheels - #1030

Merged
daniel-sanche merged 2 commits into
mainfrom
parthea-patch-2
Mar 22, 2025
Merged

fix: remove setup.cfg configuration for creating universal wheels#1030
daniel-sanche merged 2 commits into
mainfrom
parthea-patch-2

Conversation

@parthea

Copy link
Copy Markdown
Contributor

setup.cfg contains a setting to create a Universal Wheel which is only needed if libraries support both Python 2 and Python 3. This library only supports Python 3 so this setting is no longer needed. See https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#wheels.

See similar PR googleapis/google-cloud-python#13659 which includes this stack trace

 running bdist_wheel
/tmp/pip-build-env-9o_3w17v/overlay/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:135: SetuptoolsDeprecationWarning: bdist_wheel.universal is deprecated
!!
********************************************************************************
With Python 2.7 end-of-life, support for building universal wheels
(i.e., wheels that support both Python 2 and Python 3)
is being obviated.
Please discontinue using this option, or if you still need it,
file an issue with pypa/setuptools describing your use case.
By 2025-Aug-30, you need to update your project and remove deprecated calls
or your builds will no longer be supported.
********************************************************************************
!!

@parthea
parthea requested review from a teamMarch 14, 2025 13:15
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Mar 14, 2025
@daniel-sanche
daniel-sanche enabled auto-merge (squash) March 21, 2025 23:58
@daniel-sanche
daniel-sanche merged commit 727098b into mainMar 22, 2025
@daniel-sanche
daniel-sanche deleted the parthea-patch-2 branch March 22, 2025 00:32
@release-pleaserelease-pleaseBot mentioned this pull request Mar 22, 2025
gkevinzheng pushed a commit that referenced this pull request Apr 30, 2025
)
Co-authored-by: Daniel Sanche <sanche@google.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestoreIssues related to the googleapis/python-firestore API.size: xsPull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@parthea@daniel-sanche@ohmayr@cindy-peng