Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

feat: query to pipeline conversion - #1071

Merged
daniel-sanche merged 256 commits into
pipeline_queries_approvedfrom
pipeline_queries_3_5_query_conversion
Oct 23, 2025
Merged

feat: query to pipeline conversion#1071
daniel-sanche merged 256 commits into
pipeline_queries_approvedfrom
pipeline_queries_3_5_query_conversion

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Jun 24, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR extends pipeline expressions to allow converting from a Query to a Pipeline expression. All necessary stages and expressions have been added

Many existing system tests have been extended to run many queries in both RunQuery and PipelineQuery mode, and compare results for consistency

@daniel-sanche
added basic pipelines.py file
cd2963d
@daniel-sanche
added yaml test file
3cbc2d5
@daniel-sanche
wrote basic parser for pipeline yaml
0c2241d
@daniel-sanche
encoded extra java system tests
9c8982c
@daniel-sanche
reconstruct pipeline expr objects
863bd1d
@daniel-sanche
got yaml to run
7cd2c11
@daniel-sanche
add data loading code
c328934
@daniel-sanche
updated protos
de0a862
@daniel-sanche
added pyyaml to system test dependencies
45c83aa
@daniel-sanche
added Expr methods
fc57f04
@daniel-sanche
trying to improve accumulator api
0224f94
@daniel-sanche
improved aggregate/accumulators
cdee937
@daniel-sanche
fixed naming in yaml
5d35c54
@daniel-sanche
create objects in parsing code
11373e3
@daniel-sanche
use order enum
d2b4153
@daniel-sanche
standardize how I deal with map stages
bfdfba3
@daniel-sanche
fix broke super.__init__ calls
afa823a
@daniel-sanche
added repr for custom classes
3348127
@daniel-sanche
added repr to pipeline
e3c995d
@daniel-sanche
fixed vector formatting
2d604e1
@daniel-sanche
only treat capitalized strings as possible exprs
3bed807
@daniel-sanche
Where uses positional args in yaml
9b9eaa8
@daniel-sanche
support union stage
e35accf
@daniel-sanche
fixed testReplace
72301a1
@daniel-sanche
fixed sample
07d25dc
@daniel-sanche
iterating on sample options
38fb7fa
@daniel-sanche
fixed import
0c3852f
@daniel-sanche
removing kwargs
1d95e54
@daniel-sanche
removing keargs
a3daa07
@daniel-sanche
use only positional arguments in yaml
8e45b68
@product-auto-labelproduct-auto-labelBot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Oct 21, 2025
@daniel-sanche
daniel-sanche changed the base branch from pipeline_queries_approved to pipeline_queries_fixedOctober 21, 2025 23:54
Base automatically changed from pipeline_queries_fixed to pipeline_queries_approvedOctober 22, 2025 23:53
@daniel-sanchedaniel-sanche changed the title [DRAFT] feat: query to pipeline conversionfeat: query to pipeline conversionOct 22, 2025
bhshkh
bhshkh approved these changes Oct 23, 2025
View reviewed changes
Comment threadgoogle/cloud/firestore_v1/base_aggregation.py Outdated
@daniel-sanche@bhshkh
Update google/cloud/firestore_v1/base_aggregation.py
0ea73f9
Co-authored-by: Baha Aiman <bahaaiman@google.com>
@daniel-sanche
daniel-sanche merged commit fed7af2 into pipeline_queries_approvedOct 23, 2025
3 of 4 checks passed
@daniel-sanche
daniel-sanche deleted the pipeline_queries_3_5_query_conversion branch October 23, 2025 20:54
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@bhshkhbhshkhbhshkh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kevkim-codeskevkim-codes

Labels

api: firestoreIssues related to the googleapis/python-firestore API.size: xlPull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daniel-sanche@bhshkh@kevkim-codes@yoshi-kokoro