Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

feat: Additional Pipeline Expressions - #1115

Merged
daniel-sanche merged 14 commits into
pipeline_queries_approvedfrom
pipeline_queries_new_exprs
Oct 29, 2025
Merged

feat: Additional Pipeline Expressions#1115
daniel-sanche merged 14 commits into
pipeline_queries_approvedfrom
pipeline_queries_new_exprs

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Oct 25, 2025

Copy link
Copy Markdown
Contributor

Adds remaining pipeline expressions

@daniel-sanche
daniel-sanche requested review from a teamOctober 25, 2025 00:11
@product-auto-labelproduct-auto-labelBot added the size: xl Pull request size is extra large. label Oct 25, 2025
@product-auto-labelproduct-auto-labelBot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 25, 2025
@ehsannasehsannas removed their assignment Oct 28, 2025

@bhshkhbhshkh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Overall LGTM.


@expose_as_static
def map_remove(self, key: str | Constant[str]) -> "Expr":
"""Remove a key from a the map produced by evaluating this expression.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Removeakeyfromathemapproducedbyevaluatingthisexpression.
"""Removeakeyfromthemapproducedbyevaluatingthisexpression.

>>> Field.of("address").map_remove("city")

Args:
key: The key to ewmove in the map.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: Thekeytoewmoveinthemap.
key: Thekeytoremoveinthemap.

>>> Expr.array(["bar", Field.of("baz")])

Args:
elements: THe input list to evaluate in the expression

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elements: THeinputlisttoevaluateintheexpression
elements: Theinputlisttoevaluateintheexpression

>>> Expr.map({"foo": "bar", "baz": Field.of("baz")})

Args:
elements: THe input dict to evaluate in the expression

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elements: THeinputdicttoevaluateintheexpression
elements: Theinputdicttoevaluateintheexpression

@daniel-sanche

Copy link
Copy Markdown
ContributorAuthor

Thanks, good catches!

@daniel-sanche
daniel-sanche merged commit 643f014 into pipeline_queries_approvedOct 29, 2025
4 checks passed
@daniel-sanche
daniel-sanche deleted the pipeline_queries_new_exprs branch October 29, 2025 21:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestoreIssues related to the googleapis/python-firestore API.size: xlPull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-sanche@bhshkh@ehsannas