Uh oh!
There was an error while loading. Please reload this page.
fix: remove unnecessary dependency on libcst and scripts - #220
Conversation
HemangChothani
commented
Oct 9, 2020
@tres I found in bigquery PR , that they deleted the file and enter in exclude in syth.py so followed the same. Please guide the correct way. |
tseaver
commented
Oct 9, 2020
@busunkim96 you specified in #218 that the fix was to remove the dependency, and update the script(s) to raise an error if |
HemangChothani
commented
Oct 20, 2020
@busunkim96 Could you please give some clarification? |
crwilcox
commented
Oct 20, 2020
I can weigh in here also. the script has value, but libcst is only needed for the script. We shouldn't list it in our dependencies. Instead, we should import it, catch the import error, and end the script with a message explaining the user should @tswast was the script not useful for bigquery by chance? |
tswast
commented
Oct 20, 2020
Correct. It was useless for BigQuery since we wrap the client objects in the BigQuery Storage API and in the core library we don't use the client objects at all. We only need the generator to make the compiled protos in the core library. Still, I think it makes sense to make |
… into firestore_issue_218
3a0f486 to
eacf4b1CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fixes#218