Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

tests: allow prerelease deps on Python 3.9 - #415

Merged
tseaver merged 2 commits into
masterfrom
414-test-against-prerelease-deps-under-3.9
Aug 12, 2021
Merged

tests: allow prerelease deps on Python 3.9#415
tseaver merged 2 commits into
masterfrom
414-test-against-prerelease-deps-under-3.9

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Closes#414.

@tseaver
tseaver requested review from a team, craiglabenz and crwilcoxAugust 5, 2021 20:04
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2021
@product-auto-labelproduct-auto-labelBot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 5, 2021
@crwilcox

Copy link
Copy Markdown
Contributor

@tseaver is this just open to run CI or is the goal to merge this in? Is there any concern about getting other prereleases?

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@crwilcox

Is this just open to run CI or is the goal to merge this in? Is there any concern about getting other prereleases?

I meant it to be merged, so that we get notified ASAP when a pre-release dependency breaks our tests.

@tseaver
tseaver merged commit a1e9a16 into masterAug 12, 2021
@tseaver
tseaver deleted the 414-test-against-prerelease-deps-under-3.9 branch August 12, 2021 02:16
tseaver added a commit that referenced this pull request Aug 17, 2021
gcf-merge-on-greenBot pushed a commit that referenced this pull request Aug 18, 2021
Reverts #415
Consensus from today's meeting is that testing prereleases of third-party dependencies needs to happen outside the normal `presubmit` path.
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Nov 24, 2025
Reverts googleapis/python-firestore#415
Consensus from today's meeting is that testing prereleases of third-party dependencies needs to happen outside the normal `presubmit` path.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestoreIssues related to the googleapis/python-firestore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests against pre-release versions of dependencies

2 participants

@tseaver@crwilcox