Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

fix: logger uses default resource - #207

Merged
daniel-sanche merged 9 commits into
masterfrom
refactor-python-env
Mar 9, 2021
Merged

fix: logger uses default resource#207
daniel-sanche merged 9 commits into
masterfrom
refactor-python-env

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Mar 8, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

We recently made changes to allow default resource auto-detection when using the logging handlers. This PR adds the same feature to regular Logger objects for better feature parity.

This PR also pulls in refactored environment tests from the submodule repo

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2021
@product-auto-labelproduct-auto-labelBot added the api: logging Issues related to the googleapis/python-logging API. label Mar 8, 2021
@daniel-sanchedaniel-sanche changed the title [DRAFT]: tests: refactor environment tests[DRAFT]: fix: logger uses default resourceMar 8, 2021
@daniel-sanche
daniel-sanche marked this pull request as ready for review March 8, 2021 23:14
@daniel-sanche
daniel-sanche requested review from a teamMarch 8, 2021 23:14
@daniel-sanchedaniel-sanche changed the title [DRAFT]: fix: logger uses default resourcefix: logger uses default resourceMar 8, 2021
@daniel-sanchedaniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2021
@daniel-sanchedaniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2021
@simonz130simonz130 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 9, 2021
@daniel-sanche
daniel-sanche merged commit 0f90a79 into masterMar 9, 2021
@daniel-sanche
daniel-sanche deleted the refactor-python-env branch March 9, 2021 19:45
@daniel-sanchedaniel-sanche mentioned this pull request Mar 23, 2021
Merged
@daniel-sanchedaniel-sanche mentioned this pull request Jun 4, 2021
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@simonz130simonz130simonz130 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: loggingIssues related to the googleapis/python-logging API.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-sanche@simonz130@yoshi-kokoro