Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

fix(deps): allow protobuf 3.19.5 - #644

Merged
vchudnov-g merged 2 commits into
mainfrom
allow-protobuf-3-19-5
Oct 7, 2022
Merged

fix(deps): allow protobuf 3.19.5#644
vchudnov-g merged 2 commits into
mainfrom
allow-protobuf-3-19-5

Conversation

@parthea

Copy link
Copy Markdown
Contributor

No description provided.

@parthea
parthea requested review from a teamOctober 6, 2022 20:05
@product-auto-labelproduct-auto-labelBot added the size: xs Pull request size is extra small. label Oct 6, 2022
@product-auto-labelproduct-auto-labelBot added the api: logging Issues related to the googleapis/python-logging API. label Oct 6, 2022
Comment threadsetup.py
"grpc-google-iam-v1 >=0.12.4, <1.0.0dev",
"proto-plus >= 1.22.0, <2.0.0dev",
"protobuf >= 3.20.2, <5.0.0dev",
"protobuf>=3.19.5,<5.0.0dev,!=3.20.0,!=3.20.1,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some context here? Why are these versions disallowed?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See go/tensorflow-python-client-libaries-dependency-issue internally

Comment threadsetup.py
"grpc-google-iam-v1 >=0.12.4, <1.0.0dev",
"proto-plus >= 1.22.0, <2.0.0dev",
"protobuf >= 3.20.2, <5.0.0dev",
"protobuf>=3.19.5,<5.0.0dev,!=3.20.0,!=3.20.1,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See go/tensorflow-python-client-libaries-dependency-issue internally

@vchudnov-g
vchudnov-g merged commit 12f3001 into mainOct 7, 2022
@vchudnov-g
vchudnov-g deleted the allow-protobuf-3-19-5 branch October 7, 2022 20:50
@release-pleaserelease-pleaseBot mentioned this pull request Oct 7, 2022
parthea added a commit that referenced this pull request Oct 10, 2022
Co-authored-by: Daniel Sanche <sanche@google.com>
@partheaparthea mentioned this pull request Oct 10, 2022
parthea added a commit that referenced this pull request Oct 10, 2022
* fix(deps): allow protobuf 3.19.5 (#644)
Co-authored-by: Daniel Sanche <sanche@google.com>
* update version/changelog
Co-authored-by: Daniel Sanche <sanche@google.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: loggingIssues related to the googleapis/python-logging API.size: xsPull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea@daniel-sanche@vchudnov-g