Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 13, 2026. It is now read-only.
feat: set partial_success to default to true for batched logs - #649
Merged
Conversation
losalex
reviewed
Oct 13, 2022
Uh oh!
There was an error while loading. Please reload this page.
losalex
reviewed
Oct 13, 2022
losalex
left a comment
Contributor
There was a problem hiding this comment.
Left a comment, lets have a discussion about it
daniel-sanche
marked this pull request as ready for review
October 17, 2022 17:28
losalex
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, if one log in a batch fails (ex: due to large size), the entire batch will be dropped. This PR sets the
partial_successflag by default, so other logs will still be processed. We also exposepartial_successas an optional argument tobatch.commit(), so users can override the behavior if needed.Note that most
logger.logfunctions only typically write a single log entries, so this functionality is only strictly needed for batching. The only exception is when writing instrumentation logs, where alogger.logcall may write two entries. For this reason,partial_successis always set to true for these callsFixes#448