Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

test: update tests to support latest google-cloud-core - #66

Closed
tswast wants to merge 7 commits into
googleapis:masterfrom
tswast:google-cloud-core-1.4.2rc1
Closed

test: update tests to support latest google-cloud-core#66
tswast wants to merge 7 commits into
googleapis:masterfrom
tswast:google-cloud-core-1.4.2rc1

Conversation

@tswast

@tswasttswast commented Sep 23, 2020

Copy link
Copy Markdown
Contributor

google-cloud-core version 1.4.2 populates prettyPrint=false by
default. Update the connection tests to expect a value for
prettyPrint.

This PR also serves to test that the changes in googleapis/python-cloud-core#28 do not break this library.

Closes: #64.

`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
@tswasttswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 23, 2020
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@product-auto-labelproduct-auto-labelBot added the api: logging Issues related to the googleapis/python-logging API. label Sep 24, 2020
@tswast
tswast requested a review from a teamSeptember 29, 2020 19:48
@tswasttswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2020
@tseaver

Copy link
Copy Markdown
Contributor

Python 3.6 systest failure due to #64.

daniel-sanche added a commit that referenced this pull request Oct 15, 2020
@daniel-sanche

Copy link
Copy Markdown
Contributor

Thanks Tim! I was actually working on a separate PR to fix this and other failing tests here. Since we can't merge this PR until the other fixes are in, I pulled your changes over there, and I'll close this one. Let me know if you have any other suggestions in #70

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: loggingIssues related to the googleapis/python-logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update system test PubSub calls or change PubSub deps

3 participants

@tswast@tseaver@daniel-sanche