Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

fix: instrumentation entries should not contain user labels - #703

Merged
daniel-sanche merged 6 commits into
mainfrom
instrumentation_no_labels_2
Jan 17, 2023
Merged

fix: instrumentation entries should not contain user labels#703
daniel-sanche merged 6 commits into
mainfrom
instrumentation_no_labels_2

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Previously, instrumentation logs would inherit labels and other log metadata from the parent log. This was causing issues when the user expected logs with certain labels to conform to a set structure, which the instrumentation log would break

Instead, instrumentation logs should be static, containing only a severity field

@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Jan 12, 2023
@product-auto-labelproduct-auto-labelBot added the api: logging Issues related to the googleapis/python-logging API. label Jan 12, 2023
@daniel-sanche
daniel-sanche marked this pull request as ready for review January 14, 2023 01:04
@daniel-sanche
daniel-sanche requested review from a teamJanuary 14, 2023 01:04
daniel-sanche
daniel-sanche commented Jan 14, 2023
View reviewed changes
Comment threadgoogle/cloud/logging_v2/_instrumentation.py Outdated
@losalexlosalex self-assigned this Jan 16, 2023
losalex
losalex reviewed Jan 16, 2023
View reviewed changes
Comment threadgoogle/cloud/logging_v2/_instrumentation.py Outdated
losalex
losalex reviewed Jan 16, 2023
View reviewed changes
Comment threadtests/unit/test__instrumentation.py
losalex
losalex approved these changes Jan 16, 2023
View reviewed changes

@losalexlosalex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please see my comments regarding severity and extra test checking only required fields are present

@daniel-sanche
daniel-sanche merged commit e05d132 into mainJan 17, 2023
@daniel-sanche
daniel-sanche deleted the instrumentation_no_labels_2 branch January 17, 2023 23:12
@release-pleaserelease-pleaseBot mentioned this pull request Jan 17, 2023
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@losalexlosalexlosalex approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@losalexlosalex

Labels

api: loggingIssues related to the googleapis/python-logging API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daniel-sanche@losalex