Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

feat: structured log adapter - #751

Closed
NewGlad wants to merge 11 commits into
googleapis:mainfrom
NewGlad:main
Closed

feat: structured log adapter#751
NewGlad wants to merge 11 commits into
googleapis:mainfrom
NewGlad:main

Conversation

@NewGlad

@NewGladNewGlad commented May 25, 2023

Copy link
Copy Markdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) Do I need to update docs?

Fixesgoogleapis/google-cloud-python#15414 🦕

@NewGlad
NewGlad requested review from a teamMay 25, 2023 07:11
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-labelproduct-auto-labelBot added the size: m Pull request size is medium. label May 25, 2023
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented May 25, 2023

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added the api: logging Issues related to the googleapis/python-logging API. label May 25, 2023
@NewGlad

Copy link
Copy Markdown
Author

@daniel-sanche could you help, is there a way to run tests and linter in GitHub actions for my changes?

@NewGlad
NewGladforce-pushed the main branch 2 times, most recently from fe4e4f7 to 79c24f8CompareMay 25, 2023 08:08
@product-auto-labelproduct-auto-labelBot added the stale: old Pull request is old and needs attention. label Jun 24, 2023
@product-auto-labelproduct-auto-labelBot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Jul 24, 2023
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 9, 2023
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@partheaparthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 9, 2023
@daniel-sanchedaniel-sanche added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 25, 2023
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 25, 2023
@daniel-sanchedaniel-sanche changed the title Add AppendLabelLoggingAdapter to have an ability to adapt logger with…feat: structured log adapterSep 25, 2023
@NewGlad

Copy link
Copy Markdown
Author

@daniel-sanche
Any chance of getting a review for this PR?

@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2026
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2026
@chalmerlowechalmerlowe added kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 19, 2026
@chalmerlowe

Copy link
Copy Markdown

@NewGlad If you are still interested in this PR, please sign the CLA. See this comment.

I know it has been three years. Sorry.

@chalmerlowechalmerlowe added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 19, 2026
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2026
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2026
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2026
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2026
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2026
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 20, 2026
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2026
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2026
@chalmerlowechalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2026
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2026

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe

Copy link
Copy Markdown

Gonna close this for now to allow us to migrate this repo to the google-cloud-python mono-repo.

Will re-open it there and see about finishing it then.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: loggingIssues related to the googleapis/python-logging API.size: lPull request size is large.stale: extraoldPull request is critically old and needs prioritization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add StructuredLogHandler adapter

6 participants

@NewGlad@chalmerlowe@daniel-sanche@parthea@yoshi-kokoro@gkevinzheng