Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

fix: Use warning instead of warn in system tests to avoid DeprecationWarning - #821

Merged
gkevinzheng merged 3 commits into
mainfrom
use-warning
Dec 5, 2023
Merged

fix: Use warning instead of warn in system tests to avoid DeprecationWarning#821
gkevinzheng merged 3 commits into
mainfrom
use-warning

Conversation

@gkevinzheng

@gkevinzhenggkevinzheng commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Fixes#820 🦕

@gkevinzheng
gkevinzheng requested a review from a teamDecember 4, 2023 16:05
@gkevinzheng
gkevinzheng requested a review from a teamDecember 4, 2023 16:05
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/python-logging API. labels Dec 4, 2023
parthea
parthea approved these changes Dec 4, 2023
View reviewed changes

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also remove the line in pytest.ini which ignores the warning

python-logging/pytest.ini

Lines 20 to 21 in 0ba8220

# Remove once https://github.com/googleapis/python-logging/issues/820 is fixed
ignore:.*warn.*is deprecated, use.*warning.*instead:DeprecationWarning

@gkevinzheng
gkevinzheng merged commit c447175 into mainDec 5, 2023
@gkevinzheng
gkevinzheng deleted the use-warning branch December 5, 2023 18:39
@release-pleaserelease-pleaseBot mentioned this pull request Dec 5, 2023
Merged
@partheaparthea mentioned this pull request Dec 11, 2023
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@partheapartheaparthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@partheaparthea

Labels

api: loggingIssues related to the googleapis/python-logging API.size: xsPull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeprecationWarning in Kokoro build log The 'warn' method is deprecated, use 'warning' instead

2 participants

@gkevinzheng@parthea