Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

chore: add samples to microgen - #89

Merged
daniel-sanche merged 53 commits into
microgenfrom
add-samples-to-microgen
Nov 12, 2020
Merged

chore: add samples to microgen#89
daniel-sanche merged 53 commits into
microgenfrom
add-samples-to-microgen

Conversation

@busunkim96

Copy link
Copy Markdown
Contributor

Syncing microgen branch with main branch.

Jon Wayne Parrottand others added 30 commits October 30, 2020 17:57
Change-Id: I67e149dc43ebdb11144ac3839e062aa4668ebb2e
Change-Id: I866edcc956fda2265dd7af7b774336930ec6a151
Change-Id: Ieaf7237fc6f925daec46a07d2e81a452b841198a
…samples#887)
* Remove cloud config fixture
* Fix client secrets
* Fix bigtable instance
…mples#914)
* Auto-update dependencies.
* xfail the error reporting test
* Fix lint
…amples#1004)
* Auto-update dependencies.
* Fix natural language samples
* Fix pubsub iam samples
* Fix language samples
* Fix bigquery samples
…amples#1055)
* Auto-update dependencies.
* Explicitly use latest bigtable client
Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e
* Revert language update for now
Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53
* Remove pdb. smh
Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43
Change-Id: I6691c70912b1e1b5993e962a4827a846642feac3
…amples#1093)
* Auto-update dependencies.
* Fix storage notification poll sample
Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3
* Fix spanner samples
Change-Id: I40069222c60d57e8f3d3878167591af9130895cb
* Drop coverage because it's not useful
Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522
* Try again to fix flaky logging test
Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4
…-docs-samples#1158)
* Update Readme.rst to add Python setup guide
As requested in b/64770713.
This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation.
* Update README.rst
* Update README.rst
* Update README.rst
* Update README.rst
* Update README.rst
* Update install_deps.tmpl.rst
* Updated readmegen scripts and re-generated related README files
* Fixed the lint error
Change-Id: I0d420f3053f391fa225e4b8179e45fd1138f5c65
GoogleCloudPlatform/python-docs-samples#1233)
* Add sample for standard library logging handler configuration
* Add handler.py to readme
Comment threadnoxfile.py
os.path.join("docs", "_build", "doctrees", ""),
os.path.join("docs", ""),
os.path.join("docs", "_build", "html", ""),
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? Won't this get overwritten by the upstream since we're now using synthtool for this file?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This session was duplicated on accident (see docfx below)

Comment threadsamples/snippets/README.rst Outdated

.. This file is automatically generated. Do not edit this file directly.

Stackdriver Logging Python Samples

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is outdated branding. We should call it Cloud Logging now

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment threadsamples/snippets/README.rst Outdated
Install Dependencies
++++++++++++++++++++

#. Clone python-docs-samples and change directory to the sample directory you want to use.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not python-docs-samples anymore

@busunkim96busunkim96 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2020

@leahecoleleahecole left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Dan's comments, and if we can re-run to pick up the samples noxfile change with the type hint config that would also be sweet

Comment threadsamples/snippets/README.rst Outdated

.. This file is automatically generated. Do not edit this file directly.

Stackdriver Logging Python Samples

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@google-cla

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-clagoogle-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 11, 2020
@google-cla

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@busunkim96busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 11, 2020
@google-cla

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-clagoogle-claBot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 11, 2020
@busunkim96busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 12, 2020

@leahecoleleahecole left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as Dan's happy I'm happy

@daniel-sanchedaniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniel-sanche
daniel-sanche merged commit 09feb3a into microgenNov 12, 2020
@busunkim96
busunkim96 deleted the add-samples-to-microgen branch November 12, 2020 22:14
@busunkim96busunkim96 mentioned this pull request Nov 17, 2020
busunkim96 added a commit that referenced this pull request Nov 17, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@busunkim96@daniel-sanche@leahecole@dpebot@jmdobry@waprin@andrewsg@frankyn@SurferJeffAtGoogle@gguuss@renovate-bot@kurtisvg@darrencarlton