Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

Implement Future.cancel() - #204

Merged
chrisrossi merged 1 commit into
googleapis:masterfrom
chrisrossi:cancel
Sep 17, 2019
Merged

Implement Future.cancel()#204
chrisrossi merged 1 commit into
googleapis:masterfrom
chrisrossi:cancel

Conversation

@chrisrossi

Copy link
Copy Markdown
Contributor

This brings our implementation of Future in parity with the
Future interface defined in the Python 3 standard library, and makes
it possible to cancel asynchronous grpc calls from NDB.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2019
This brings our implementation of ``Future`` in parity with the
``Future`` interface defined in the Python 3 standard library, and makes
it possible to cancel asynchronous ``grpc`` calls from NDB.

@cguardiacguardia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

@chrisrossichrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2019
@chrisrossi
chrisrossi merged commit 62e65cc into googleapis:masterSep 17, 2019
@chrisrossi
chrisrossi deleted the cancel branch September 17, 2019 19:35
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisrossi@cguardia@googlebot@yoshi-kokoro