Uh oh!
There was an error while loading. Please reload this page.
Allow class member values in projection and distinct queries - #214
Conversation
…o be strings. This commit sets the converted properties so they may be used by the rest of the query.
…o be strings. This commit sets the converted properties so they may be used by the rest of the query.
googlebot
commented
Sep 27, 2019
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
chmoder
commented
Sep 27, 2019
@googlebot I signed it! |
googlebot
commented
Sep 27, 2019
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
crwilcox
commented
Sep 30, 2019
@chmoder it seems that a unit test is failing currently |
@crwilcox, thank you. I have pushed changes to fix that along with a new test case to test |
chrisrossi
left a comment
There was a problem hiding this comment.
This looks great, thank you! I will merge once Kokoro awakens from its stupor and runs the tests.
chmoder
commented
Oct 1, 2019
Thanks Chris! I noticed the build failed due to lint checking. I ran black with kokoros build configuration and pushed that up as well. |
Yep, I was in the middle of writing a not about how to use "nox" to run "blacken" when you pushed that and made my note obsolete. Thanks! |
chrisrossi
commented
Oct 1, 2019
Thank you for your bugfix @chmoder ! |
Fixes#212 by setting the projection and distinct_on lists to their
stringtype names. Before it converted them but did not set them.