Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 6, 2026. It is now read-only.
Fix Model._gql. - #223
Merged
Merged
Conversation
Binding parameters in `Model._gql` was broken due to a misplaced parenthesis. Fixesgoogleapis#222.
cguardia
approved these changes
Oct 16, 2019
cguardia
left a comment
Contributor
There was a problem hiding this comment.
Thanks for catching that one.
| ) | ||
| "SELECT * FROM {} {}".format(cls._class_name(), query_string), | ||
| *args, | ||
| **kwargs, |
Contributor
There was a problem hiding this comment.
The trailing comma here is not valid in Python 2.7. We might as well remove it now.
ContributorAuthor
There was a problem hiding this comment.
Hmm, well. Blacken added it. That's kind of a conundrum...
Contributor
There was a problem hiding this comment.
Hmm, yes, that's a problem. In this case, it might be enough to put them in the same line, but for longer call signatures it could get ugly.
ContributorAuthor
There was a problem hiding this comment.
I found a way to make blacken happy and get rid of that comma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding parameters in
Model._gqlwas broken due to a misplacedparenthesis. Fixes#222.