Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: query.map() and query.map_async() hanging with empty result set. - #230

Merged
chrisrossi merged 3 commits into
googleapis:masterfrom
chrisrossi:fix-227
Nov 6, 2019
Merged

fix: query.map() and query.map_async() hanging with empty result set.#230
chrisrossi merged 3 commits into
googleapis:masterfrom
chrisrossi:fix-227

Conversation

@chrisrossi

Copy link
Copy Markdown
Contributor

Fixes#227.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2019
@chrisrossi

Copy link
Copy Markdown
ContributorAuthor

@cguardia Can you take a look when you get a chance?

@crwilcoxcrwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2019
@andrewsg

andrewsg commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

@chrisrossi I'm seeing this in the Kokoro build failure:


==================================== ERRORS ====================================
_____________________ ERROR at teardown of test_filter_or ______________________
ds_client = <google.cloud.datastore.client.Client object at 0x7f6318196860>
to_delete = [<Key('SomeKind', 5723651571712000), project=precise-truck-742>, <Key('SomeKind', 5160701618290688), project=precise-truck-742>, <Key('SomeKind', 6286601525133312), project=precise-truck-742>]
deleted_keys = {<Key('SomeKind', 6376074283843584), project=precise-truck-742>, <Key('SomeKind', 5540445446733824), project=precise-t...d', 4796636970614784), project=precise-truck-742>, <Key('SomeKind', 6098997353644032), project=precise-truck-742>, ...}
@pytest.fixture
def with_ds_client(ds_client, to_delete, deleted_keys):
# Make sure we're leaving database as clean as we found it after each test
results = [
entity
for entity in all_entities(ds_client)
if entity.key not in deleted_keys
]
assert not results
yield ds_client
if to_delete:
ds_client.delete_multi(to_delete)
deleted_keys.update(to_delete)
not_deleted = [
entity
for entity in all_entities(ds_client)
if entity.key not in deleted_keys
]
> assert not not_deleted
E AssertionError: assert not [<Entity('SomeKind', 5112361526493184) {'foo': 1, 'bar': 'a'}>]
tests/system/conftest.py:76: AssertionError

@chrisrossichrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2019
@chrisrossi
chrisrossi merged commit 0561a34 into googleapis:masterNov 6, 2019
@chrisrossi
chrisrossi deleted the fix-227 branch November 6, 2019 18:38
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

query.map() and query.map_async() hangs when query returns no results

5 participants

@chrisrossi@andrewsg@crwilcox@googlebot@yoshi-kokoro