Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: Finish implementation of UserProperty. - #301

Merged
chrisrossi merged 2 commits into
googleapis:masterfrom
chrisrossi:UserProperty
Jan 28, 2020
Merged

fix: Finish implementation of UserProperty.#301
chrisrossi merged 2 commits into
googleapis:masterfrom
chrisrossi:UserProperty

Conversation

@chrisrossi

Copy link
Copy Markdown
Contributor

This never actually worked.

Fixes#280

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2020

@cguardiacguardia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment threadgoogle/cloud/ndb/model.py Outdated
return user_entity

def _from_base_type(self, ds_entity):
"""Convert the user value from a datatsore entity.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: datastore.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BadValueError when referencing ndb.UserProperty

3 participants

@chrisrossi@cguardia@googlebot