Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: Fix bug when wrapping base values. - #303

Merged
chrisrossi merged 1 commit into
googleapis:masterfrom
chrisrossi:fix-300
Jan 28, 2020
Merged

fix: Fix bug when wrapping base values.#303
chrisrossi merged 1 commit into
googleapis:masterfrom
chrisrossi:fix-300

Conversation

@chrisrossi

@chrisrossichrisrossi commented Jan 28, 2020

Copy link
Copy Markdown
Contributor

Fixes#300.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2020
cguardia
cguardia approved these changes Jan 28, 2020
View reviewed changes

@cguardiacguardia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chrisrossi
chrisrossi merged commit 91ca8d9 into googleapis:masterJan 28, 2020
@chrisrossi
chrisrossi deleted the fix-300 branch January 28, 2020 20:04
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewsgandrewsgAwaiting requested review from andrewsg
@crwilcoxcrwilcoxAwaiting requested review from crwilcox
1 more reviewer
@cguardiacguardiacguardia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[python 2.7, google-cloud-ndb==0.2.0] StringProperty(repeated=True) deserializes list of empty strings into list of None

3 participants

@chrisrossi@cguardia@googlebot