Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: remove pytz - #707

Merged
chrisrossi merged 5 commits into
masterfrom
remove-pytz
Aug 12, 2021
Merged

fix: remove pytz#707
chrisrossi merged 5 commits into
masterfrom
remove-pytz

Conversation

@busunkim96

@busunkim96busunkim96 commented Aug 12, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

@busunkim96
busunkim96 requested review from a teamAugust 12, 2021 20:21
@product-auto-labelproduct-auto-labelBot added the api: datastore Issues related to the googleapis/python-ndb API. label Aug 12, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@busunkim96busunkim96 mentioned this pull request Aug 12, 2021
Closed
@chrisrossi

chrisrossi commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

This appears to be a whitespace-only change.

@chrisrossi

chrisrossi commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

This appears to be a whitespace-only change.

Nevermind, was accidentally looking at diff for single commit

@chrisrossi

chrisrossi commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Unfortunately, NDB is still required to support Python 2.7, where datetime.timezone.utc is not present. If I understand the problem to be addressed properly, we probably just need to add the pytz dependency to setup.py instead.

@busunkim96

busunkim96 commented Aug 12, 2021

Copy link
Copy Markdown
ContributorAuthor

@chrisrossi Ah makes sense. I backed out the original changes and just added pytz to the setup.py.

chrisrossi
chrisrossi approved these changes Aug 12, 2021
View reviewed changes

@chrisrossichrisrossi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisrossi
chrisrossi merged commit 6b48548 into masterAug 12, 2021
@chrisrossi
chrisrossi deleted the remove-pytz branch August 12, 2021 23:02
oliverchang added a commit to google/clusterfuzz that referenced this pull request Aug 27, 2021
@oliverchang
Add missing pytz dependency to setup.py.
cb7c3cc
Due to googleapis/python-ndb#707.
@oliverchangoliverchang mentioned this pull request Aug 27, 2021
Merged
oliverchang added a commit to google/clusterfuzz that referenced this pull request Aug 27, 2021
@oliverchang
Add missing pytz dependency to setup.py. (#2436)
1addf69
Due to googleapis/python-ndb#707.
gcf-merge-on-greenBot pushed a commit that referenced this pull request Sep 1, 2021
@release-please
chore: release 1.10.2 (#708)
e959f4f
🤖 I have created a release \*beep\* \*boop\*
---
### [1.10.2](https://www.github.com/googleapis/python-ndb/compare/v1.10.1...v1.10.2) (2021-08-31)
### Bug Fixes
* **deps:** add pytz as an explicit dependency ([#707](https://www.github.com/googleapis/python-ndb/issues/707)) ([6b48548](https://www.github.com/googleapis/python-ndb/commit/6b48548a1ea4b0c125314f907c25b47992ee6556))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewsgandrewsgAwaiting requested review from andrewsg
1 more reviewer
@chrisrossichrisrossichrisrossi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastoreIssues related to the googleapis/python-ndb API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@busunkim96@chrisrossi