Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

chore: Remove reference to CircleCI in CONTRIBUTING.rst - #806

Merged
gcf-merge-on-green[bot] merged 1 commit into
googleapis:mainfrom
bw-yuhogg:remove-circleci-reference
Oct 18, 2022
Merged

chore: Remove reference to CircleCI in CONTRIBUTING.rst#806
gcf-merge-on-green[bot] merged 1 commit into
googleapis:mainfrom
bw-yuhogg:remove-circleci-reference

Conversation

@bw-yuhogg

Copy link
Copy Markdown
Contributor

That file was deleted in #687

@bw-yuhogg
bw-yuhogg requested a review from a teamOctober 6, 2022 15:12
@product-auto-labelproduct-auto-labelBot added the api: datastore Issues related to the googleapis/python-ndb API. label Oct 6, 2022

@dandhleedandhlee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(docs triggers a new release, this is internal so chore or cleanup would be a better prefix)

@dandhleedandhlee changed the title docs: Remove reference to CircleCI in CONTRIBUTING.rstchore: Remove reference to CircleCI in CONTRIBUTING.rstOct 6, 2022
@dandhleedandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 6, 2022
@bw-yuhogg

Copy link
Copy Markdown
ContributorAuthor

I opened #807 to try and fix that docs-presubmit issue

@dandhlee

Copy link
Copy Markdown
Contributor

It's an optional presubmit so it's fine for this PR to merge.

@dandhleedandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2022
@bw-yuhogg
bw-yuhoggforce-pushed the remove-circleci-reference branch from c6c0680 to ce03571CompareOctober 17, 2022 18:55
@bw-yuhogg
bw-yuhoggforce-pushed the remove-circleci-reference branch from ce03571 to ef629b9CompareOctober 18, 2022 14:34
@bw-yuhogg

Copy link
Copy Markdown
ContributorAuthor

@dandhlee can we merge this?

@dandhleedandhlee added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. automerge Merge the pull request once unit tests and other checks pass. labels Oct 18, 2022
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit aecd927 into googleapis:mainOct 18, 2022
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2022
@bw-yuhogg
bw-yuhogg deleted the remove-circleci-reference branch June 22, 2023 18:53
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastoreIssues related to the googleapis/python-ndb API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bw-yuhogg@dandhlee@yoshi-kokoro