Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: Typecheck errors in samples/snippets/subscriber.py - #1186

Merged
mukund-ananthu merged 7 commits into
mainfrom
snippetsTypeFix
Jun 7, 2024
Merged

fix: Typecheck errors in samples/snippets/subscriber.py#1186
mukund-ananthu merged 7 commits into
mainfrom
snippetsTypeFix

Conversation

@mukund-ananthu

@mukund-ananthumukund-ananthu commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Fix type check errors in the samples/snippets/subscriber.py file.

Fixes#1059 🦕

@mukund-ananthu
mukund-ananthu requested a review from a team as a code ownerJune 7, 2024 16:11
@mukund-ananthu
mukund-ananthu requested review from a team and leahecoleJune 7, 2024 16:11
@mukund-ananthumukund-ananthu self-assigned this Jun 7, 2024
@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 7, 2024
@mukund-ananthu

mukund-ananthu commented Jun 7, 2024

Copy link
Copy Markdown
ContributorAuthor

@parthea PTAL when free.

@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jun 7, 2024
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 7, 2024
parthea
parthea approved these changes Jun 7, 2024
View reviewed changes
Comment threadsamples/snippets/mypy.ini Outdated
@mukund-ananthu@parthea
Update samples/snippets/mypy.ini
a6fbe99
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@mukund-ananthu
mukund-ananthu enabled auto-merge (squash) June 7, 2024 18:28
@mukund-ananthumukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@mukund-ananthumukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@mukund-ananthumukund-ananthu added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@mukund-ananthumukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@mukund-ananthu
mukund-ananthu merged commit 3698450 into mainJun 7, 2024
@mukund-ananthu
mukund-ananthu deleted the snippetsTypeFix branch June 7, 2024 20:10
@release-pleaserelease-pleaseBot mentioned this pull request Jun 7, 2024
Merged
@shahar1shahar1 mentioned this pull request Feb 22, 2025
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leahecoleleahecoleAwaiting requested review from leahecoleleahecole is a code owner automatically assigned from googleapis/python-samples-reviewers
1 more reviewer
@partheapartheaparthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mukund-ananthumukund-ananthu

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.samplesIssues that are directly related to samples.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error: Module "google.cloud" has no attribute "pubsub_v1"

3 participants

@mukund-ananthu@parthea@yoshi-kokoro