Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: Fix flaky test - #1254

Merged
mukund-ananthu merged 1 commit into
mainfrom
ff
Sep 17, 2024
Merged

fix: Fix flaky test#1254
mukund-ananthu merged 1 commit into
mainfrom
ff

Conversation

@mukund-ananthu

Copy link
Copy Markdown
Contributor
  • OpenTelemetry does not support export of unended spans. This causes flakiness when spans that close async are present.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mukund-ananthu
mukund-ananthu requested review from a teamSeptember 17, 2024 18:56
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Sep 17, 2024
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Sep 17, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 17, 2024
@mukund-ananthu

Copy link
Copy Markdown
ContributorAuthor

@parthea PTAL

* OpenTelemetry does not support export of unended spans. This causes
flakiness when spans that close async are present.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mukund-ananthu@parthea