Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: make fixup script consistent with migration docs - #208

Merged
cguardia merged 4 commits into
googleapis:masterfrom
cguardia:199-fixup-fix
Oct 13, 2020
Merged

fix: make fixup script consistent with migration docs#208
cguardia merged 4 commits into
googleapis:masterfrom
cguardia:199-fixup-fix

Conversation

@cguardia

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#199🦕

The following changes to the fixup script are part of the PR:

  • Generate code consistent with the upgrade documentation.
  • Add an option to generate the code using keyword arguments instead of a request.
  • Generate stylistically consistent code (no spaces in keywords, double quotes for strings).
  • Reformat the script itself to use the same code styling.

@cguardia
cguardia requested a review from a teamSeptember 24, 2020 08:10
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2020
@product-auto-labelproduct-auto-labelBot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 25, 2020

@anguillanneufanguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

@cguardia
cguardia merged commit b64e218 into googleapis:masterOct 13, 2020
@release-pleaserelease-pleaseBot mentioned this pull request Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fixup_pubsub_v1_keywords.py generates incorrect output in some cases

2 participants

@cguardia@anguillanneuf