Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: remove dependency on pytz - #472

Merged
gcf-merge-on-green[bot] merged 3 commits into
masterfrom
remove-pytz
Aug 13, 2021
Merged

fix: remove dependency on pytz#472
gcf-merge-on-green[bot] merged 3 commits into
masterfrom
remove-pytz

Conversation

@busunkim96

@busunkim96busunkim96 commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

@busunkim96
busunkim96 requested review from a teamAugust 12, 2021 19:10
@product-auto-labelproduct-auto-labelBot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Aug 12, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@plamut

Copy link
Copy Markdown
Contributor

I resolved the merge conflict through the web, I think it should be fine now (no tooling at my disposal, will see what the CI checks say).

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no traces of pytz anymore, thanks for this!

@plamutplamut mentioned this pull request Aug 13, 2021
@plamut

plamut commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

The Pub/Sub Lite samples check failure is external, i.e. not caused by this PR.

Update: It was a sample for the code that had not been released yet at the time, but now a new version of Pub/Sub Lite has been released. Re-running the checks.

@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2021
@plamutplamut added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 13, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 972cc16 into masterAug 13, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the remove-pytz branch August 13, 2021 06:58
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@release-pleaserelease-pleaseBot mentioned this pull request Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing pytz dependency

3 participants

@busunkim96@plamut@yoshi-kokoro