Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

samples: add type hints to all samples - #476

Merged
gcf-merge-on-green[bot] merged 11 commits into
googleapis:masterfrom
plamut:iss-264
Aug 25, 2021
Merged

samples: add type hints to all samples#476
gcf-merge-on-green[bot] merged 11 commits into
googleapis:masterfrom
plamut:iss-264

Conversation

@plamut

@plamutplamut commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

Closes#264.

And here they are, annotated samples.

We should follow up with a pytype CI check, I'll open a separate issue for that.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
plamut requested review from a team and anguillanneufAugust 24, 2021 15:28
@plamut
plamut requested a review from a team as a code ownerAugust 24, 2021 15:28
@plamut
plamut requested review from a team and dandhleeAugust 24, 2021 15:28
@product-auto-labelproduct-auto-labelBot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Aug 24, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
anguillanneuf
anguillanneuf approved these changes Aug 24, 2021
View reviewed changes

@anguillanneufanguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Peter!

@plamutplamut added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 25, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021
@plamut

plamut commented Aug 25, 2021

Copy link
Copy Markdown
ContributorAuthor

I will follow up with adding pytype checks to leverage these type annotations and the ones we'll add to the code in the future (#477).

@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 1164890 into googleapis:masterAug 25, 2021
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2021
@plamut
plamut deleted the iss-264 branch August 25, 2021 09:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dandhleedandhleeAwaiting requested review from dandhlee
1 more reviewer
@anguillanneufanguillanneufanguillanneuf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.cla: yesThis human has signed the Contributor License Agreement.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

samples: add type hints to all samples

3 participants

@plamut@anguillanneuf@yoshi-kokoro