Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

process: add type annotations check to CI runs - #499

Merged
plamut merged 4 commits into
googleapis:mainfrom
plamut:iss-477
Sep 27, 2021
Merged

process: add type annotations check to CI runs#499
plamut merged 4 commits into
googleapis:mainfrom
plamut:iss-477

Conversation

@plamut

@plamutplamut commented Sep 17, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#477.

To verify, examine the CI logs and check that the pytype session has indeed run.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2021
@product-auto-labelproduct-auto-labelBot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 17, 2021
@plamutplamut changed the title process: add type checks to CI runsprocess: add type annotations check to CI runsSep 17, 2021
@plamutplamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@plamutplamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@plamutplamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@plamut
plamut marked this pull request as ready for review September 17, 2021 12:37
@plamut
plamut requested review from a team, anguillanneuf and pradnSeptember 17, 2021 12:37
@plamut

plamut commented Sep 17, 2021

Copy link
Copy Markdown
ContributorAuthor

FWIW, the samples failure is flakiness, will re-run when this is ready to be merged.

@plamut

plamut commented Sep 24, 2021

Copy link
Copy Markdown
ContributorAuthor

@pradn@anguillanneuf Friendly ping, this would be a useful addition, thanks!

@plamutplamut mentioned this pull request Sep 24, 2021
Closed
@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2021
@plamutplamut added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 24, 2021
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 24, 2021
@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2021
@plamut
plamut merged commit 58552e7 into googleapis:mainSep 27, 2021
@plamut
plamut deleted the iss-477 branch September 27, 2021 14:44
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pradnpradnAwaiting requested review from pradn
@anguillanneufanguillanneufAwaiting requested review from anguillanneuf
1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add type annotation checks to CI

3 participants

@plamut@busunkim96@yoshi-kokoro