Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

feat: add context manager support in client - #516

Merged
gcf-merge-on-green[bot] merged 3 commits into
mainfrom
owl-bot-a65b62ba-a695-4dea-b0c7-53e54f2db59c
Oct 9, 2021
Merged

feat: add context manager support in client#516
gcf-merge-on-green[bot] merged 3 commits into
mainfrom
owl-bot-a65b62ba-a695-4dea-b0c7-53e54f2db59c

Conversation

@gcf-owl-bot

@gcf-owl-botgcf-owl-botBot commented Oct 6, 2021

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

chore: fix docstring for first attribute of protos

committer: @busunkim96
PiperOrigin-RevId: 401271153

Source-Link: googleapis/googleapis@787f8c9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/81decffe9fc72396a8153e756d1d67a6eecfd620
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkZWNmZmU5ZmM3MjM5NmE4MTUzZTc1NmQxZDY3YTZlZWNmZDYyMCJ9

@gcf-owl-bot
feat: add context manager support in client
2972065
chore: fix docstring for first attribute of protos
committer: @busunkim96
PiperOrigin-RevId: 401271153
Source-Link: googleapis/googleapis@787f8c9
Source-Link: googleapis/googleapis-gen@81decff
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkZWNmZmU5ZmM3MjM5NmE4MTUzZTc1NmQxZDY3YTZlZWNmZDYyMCJ9
@gcf-owl-bot
gcf-owl-botBot requested review from a teamOctober 6, 2021 23:02
@trusted-contributions-gcftrusted-contributions-gcfBot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 6, 2021
@product-auto-labelproduct-auto-labelBot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Oct 6, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2021
@partheaparthea added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 7, 2021
@gcf-merge-on-green

gcf-merge-on-greenBot commented Oct 7, 2021

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@tseaver

tseaver commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

The samples failure is due to #462.

@tseaver

tseaver commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

Samples failures are due to #388.

@partheaparthea added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 8, 2021
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 8, 2021
@partheaparthea removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 8, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2021
@trusted-contributions-gcftrusted-contributions-gcfBot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 9, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 9, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2021
@partheaparthea added the automerge Merge the pull request once unit tests and other checks pass. label Oct 9, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 51eae67 into mainOct 9, 2021
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the owl-bot-a65b62ba-a695-4dea-b0c7-53e54f2db59c branch October 9, 2021 15:06
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 9, 2021
gcf-merge-on-greenBot pushed a commit that referenced this pull request Nov 10, 2021
@release-please
chore: release 2.9.0 (#522)
5c8e9db
🤖 I have created a release \*beep\* \*boop\*
---
## [2.9.0](https://www.github.com/googleapis/python-pubsub/compare/v2.8.0...v2.9.0) (2021-11-10)
### Features
* add context manager support in client ([#516](https://www.github.com/googleapis/python-pubsub/issues/516)) ([51eae67](https://www.github.com/googleapis/python-pubsub/commit/51eae67c47e2ce7d2f7620209e98df4a129801b5))
* add support for Python 3.10 ([#518](https://www.github.com/googleapis/python-pubsub/issues/518)) ([bb25d75](https://www.github.com/googleapis/python-pubsub/commit/bb25d755d70ba19e69d8a281be65f13eb994967d))
### Bug Fixes
* add 'dict' annotation type to 'request' ([b72522a](https://www.github.com/googleapis/python-pubsub/commit/b72522a4617c4b2773fb6a5a631038791aa08300))
* **deps:** drop packaging dependency ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
* **deps:** require google-api-core >= 1.28.0 ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
* improper types in pagers generation ([2ad639d](https://www.github.com/googleapis/python-pubsub/commit/2ad639d6370c7a085498595d7bd0d7eaadfff3c1))
### Documentation
* add type annotations to codebase ([#509](https://www.github.com/googleapis/python-pubsub/issues/509)) ([093cabf](https://www.github.com/googleapis/python-pubsub/commit/093cabff9f0464b1dfaa8f373b6fffbc439518de))
* list oneofs in docstring ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-pleaserelease-pleaseBot mentioned this pull request Aug 11, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@partheapartheaparthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.cla: yesThis human has signed the Contributor License Agreement.owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@parthea@yoshi-kokoro