Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

process: persist mypy session in noxfile - #546

Merged
plamut merged 5 commits into
googleapis:mainfrom
plamut:persist-nox-mypy
Dec 2, 2021
Merged

process: persist mypy session in noxfile#546
plamut merged 5 commits into
googleapis:mainfrom
plamut:persist-nox-mypy

Conversation

@plamut

@plamutplamut commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Fixes#545.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamutplamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@plamut
plamut requested review from a team and partheaDecember 2, 2021 09:37
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@product-auto-labelproduct-auto-labelBot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 2, 2021
@plamutplamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@plamutplamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@plamutplamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@plamut
plamut merged commit 0694bd4 into googleapis:mainDec 2, 2021
@plamut
plamut deleted the persist-nox-mypy branch December 2, 2021 10:36
@plamut

plamut commented Dec 2, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for the quick review, @parthea !

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@partheapartheaparthea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Persist mypy nox session

2 participants

@plamut@parthea