Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: mypy errors - #622

Merged
anguillanneuf merged 8 commits into
googleapis:mainfrom
acocuzzo:fix-mypy-errors
Mar 23, 2022
Merged

fix: mypy errors#622
anguillanneuf merged 8 commits into
googleapis:mainfrom
acocuzzo:fix-mypy-errors

Conversation

@acocuzzo

@acocuzzoacocuzzo commented Mar 22, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds checks for future is None and replaces containers.ScalarMap with Dict[type,type] in streaming_pull_manager.

Fixes#620 🦕

@acocuzzo
acocuzzo requested review from a teamMarch 22, 2022 02:53
@product-auto-labelproduct-auto-labelBot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 22, 2022
anguillanneuf
anguillanneuf suggested changes Mar 22, 2022
View reviewed changes

@anguillanneufanguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update test for google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py to bring coverage back to 100%.

pradn
pradn suggested changes Mar 22, 2022
View reviewed changes

@pradnpradn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we're getting mypy errors after these changes passed the mypy presubmit kokoro. I wonder if mypy its was changed or if we are running a newer version.

Comment threadgoogle/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated
Comment threadgoogle/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated
Comment threadgoogle/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated
Comment threadgoogle/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated
Comment threadgoogle/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated
anguillanneuf
anguillanneuf approved these changes Mar 22, 2022
View reviewed changes

@anguillanneufanguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @acocuzzo!

pradn
pradn suggested changes Mar 22, 2022
View reviewed changes
Comment threadtests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py Outdated
pradn
pradn reviewed Mar 23, 2022
View reviewed changes
Comment threadtests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py Outdated
@anguillanneuf
anguillanneuf merged commit dab13d5 into googleapis:mainMar 23, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Mar 23, 2022
Closed
@anguillanneufanguillanneuf mentioned this pull request Mar 23, 2022
Merged
@release-pleaserelease-pleaseBot mentioned this pull request Apr 6, 2022
Merged
@TonowTonow mentioned this pull request May 23, 2022
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Aug 11, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@pradnpradnpradn approved these changes
@anguillanneufanguillanneufanguillanneuf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

my/py failures on streaming_pull_manager

3 participants

@acocuzzo@pradn@anguillanneuf