Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: process ErrorInfo / GRPC errors for ack/modack only when exactly-once delivery is enabled - #626

Merged
anguillanneuf merged 7 commits into
googleapis:mainfrom
pradn:errorinfo-only-eos
Mar 29, 2022
Merged

fix: process ErrorInfo / GRPC errors for ack/modack only when exactly-once delivery is enabled#626
anguillanneuf merged 7 commits into
googleapis:mainfrom
pradn:errorinfo-only-eos

Conversation

@pradn

@pradnpradn commented Mar 28, 2022

Copy link
Copy Markdown
Contributor
  • Don't process ErrorInfo / GRPC errors at all when exactly-once is disabled.
  • Don't retry temporary errors for ack/modack RPCs when exactly-once is disabled
  • Simplify completion of futures when a RetryError occurs (there's some duplication here but its simpler b/c we don't rely on subtle behavior in the process_errors function)
  • Update tests / get to 100% test coverage

@pradn
Process EOS/GRPC errors for ack/modack only when EOS is enabled; don'…
8a54f03
…t retry temporary errors for these RPCS when EOS is disabled.
@pradn
pradn requested review from a teamMarch 28, 2022 17:38
@product-auto-labelproduct-auto-labelBot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 28, 2022
@pradn

pradn commented Mar 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Lint broken b/c psf/black#2964

acocuzzo
acocuzzo approved these changes Mar 28, 2022
View reviewed changes

@acocuzzoacocuzzo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradn

pradn commented Mar 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Waiting for upstream linter fix to make it to our CI.

@pradnpradn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2022
@pradnpradn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@pradnpradn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@pradnpradn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@anguillanneuf
anguillanneuf merged commit cc1953b into googleapis:mainMar 29, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Mar 29, 2022
Closed
@acocuzzoacocuzzo mentioned this pull request Apr 5, 2022
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Apr 6, 2022
Merged
@TonowTonow mentioned this pull request May 23, 2022
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Aug 11, 2022
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@maheshgattanimaheshgattanimaheshgattani approved these changes
@acocuzzoacocuzzoacocuzzo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@acocuzzoacocuzzo

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pradn@maheshgattani@acocuzzo@anguillanneuf@yoshi-kokoro@parthea