Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

samples(test): update exactly once delivery test - #628

Merged
anguillanneuf merged 1 commit into
mainfrom
flaky
Mar 29, 2022
Merged

samples(test): update exactly once delivery test#628
anguillanneuf merged 1 commit into
mainfrom
flaky

Conversation

@anguillanneuf

@anguillanneufanguillanneuf commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

Exactly once is a regional offering. See docs.

  • Update test to publish to a regional endpoint.
  • Remove backoff logic on exactly once delivery test because it's not needed.

@anguillanneuf
anguillanneuf requested a review from a teamMarch 29, 2022 18:54
@anguillanneuf
anguillanneuf requested a review from a team as a code ownerMarch 29, 2022 18:54
@anguillanneuf
anguillanneuf requested review from a team and leahecoleMarch 29, 2022 18:54
@product-auto-labelproduct-auto-labelBot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Mar 29, 2022
@anguillanneufanguillanneuf changed the title samples(test): use regional publisher and remove backoff on exactly once deliverysamples(test): use regional publisher, remove backoff on exactly once deliveryMar 29, 2022
@anguillanneufanguillanneuf changed the title samples(test): use regional publisher, remove backoff on exactly once deliverysamples(test): update exactly once delivery testMar 29, 2022
@anguillanneuf
anguillanneuf merged commit 7e21a32 into mainMar 29, 2022
@anguillanneuf
anguillanneuf deleted the flaky branch March 29, 2022 19:09
@acocuzzoacocuzzo mentioned this pull request Apr 5, 2022
Closed
@acocuzzoacocuzzo added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leahecoleleahecoleAwaiting requested review from leahecoleleahecole was automatically assigned from googleapis/python-samples-owners
1 more reviewer
@pradnpradnpradn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anguillanneuf@pradn@acocuzzo