Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: Add pubsub emulator support to schemas - #651

Closed
bealsao wants to merge 3 commits into
googleapis:mainfrom
bealsao:main
Closed

fix: Add pubsub emulator support to schemas#651
bealsao wants to merge 3 commits into
googleapis:mainfrom
bealsao:main

Conversation

@bealsao

Copy link
Copy Markdown

Hi All,

This is a submission to resolve issue #647 that I submitted.

The schema_service/client.py did not receive the fixes in this change: #297

So you receive the same errors as described in the issue: #290

Fixes#647

@bealsao
bealsao requested review from a teamApril 10, 2022 23:51
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 10, 2022
@bealsaobealsao changed the title Add pubsub emulator support to schemasfix: Add pubsub emulator support to schemasApr 11, 2022
@acocuzzoacocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2022
@acocuzzo

Copy link
Copy Markdown
Contributor

Hi @bealsao
Thanks so much. Because what you are changing is auto-generated code, we actually have to change our owlbot.py file to add the emulator support to our schema_service file, and then regenerate the library, so that this change is not reverted. I'm happy to do this in a separate PR that I'll link to the issue. Thanks again for your contribution!

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema api not supporting pubsub emulator

4 participants

@bealsao@acocuzzo@yoshi-kokoro@abealsgreater