Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

docs: mark exactly once as preview feature - #657

Merged
acocuzzo merged 2 commits into
googleapis:mainfrom
acocuzzo:mark-eod-preview
Apr 14, 2022
Merged

docs: mark exactly once as preview feature#657
acocuzzo merged 2 commits into
googleapis:mainfrom
acocuzzo:mark-eod-preview

Conversation

@acocuzzo

@acocuzzoacocuzzo commented Apr 14, 2022

Copy link
Copy Markdown
Contributor

Add comments to sample, as well as edit docstrings for ack, ack_with_response, modify ack deadline, and nack_with_response linking to exactly once delivery documentation.

Also swapped exactly once delivery NOT enabled descriptions to come first, so that the default case is shown first.

Fixes#617

@acocuzzo
acocuzzo requested a review from a teamApril 14, 2022 20:19
@acocuzzo
acocuzzo requested a review from a team as a code ownerApril 14, 2022 20:19
@acocuzzo
acocuzzo requested review from a team and loferrisApril 14, 2022 20:19
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 14, 2022

@anguillanneufanguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Anna.

@acocuzzo
acocuzzo merged commit 418e1a3 into googleapis:mainApr 14, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Apr 14, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Aug 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark exactly once delivery as a preview feature

2 participants

@acocuzzo@anguillanneuf