Skip to content

fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message - #312

Merged
dpcollins-google merged 5 commits into
mainfrom
dont_use_message_impl
Mar 7, 2022
Merged

fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message#312
dpcollins-google merged 5 commits into
mainfrom
dont_use_message_impl

Conversation

@dpcollins-google

Copy link
Copy Markdown
Contributor

fixes: #311

@dpcollins-google
dpcollins-google requested review from a teamMarch 7, 2022 14:43
@product-auto-labelproduct-auto-labelBot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Mar 7, 2022

@pradnpradn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change to not rely on the Message ctor. Just one comment for thought. Thanks!

@dpcollins-googledpcollins-google added the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2022
@dpcollins-google
dpcollins-google merged commit 19da693 into mainMar 7, 2022
@dpcollins-google
dpcollins-google deleted the dont_use_message_impl branch March 7, 2022 18:03
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2022
@release-pleaserelease-pleaseBot mentioned this pull request Mar 7, 2022
gcf-merge-on-greenBot pushed a commit that referenced this pull request Mar 7, 2022
🤖 I have created a release *beep* *boop*
---
### [1.4.1](v1.4.0...v1.4.1) (2022-03-07)
### Bug Fixes
* ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message ([#312](#312)) ([19da693](19da693)), closes [#311](#311)
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsubliteIssues related to the googleapis/python-pubsublite API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test test_nack_calls_ack test hangs with google-cloud-pubsub==2.10.0

3 participants

@dpcollins-google@pradn@hannahrogers-google