Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

test: update tests to support latest google-cloud-core - #23

Merged
tseaver merged 3 commits into
googleapis:masterfrom
tswast:google-cloud-core-1.4.2rc1
Oct 6, 2020
Merged

test: update tests to support latest google-cloud-core#23
tseaver merged 3 commits into
googleapis:masterfrom
tswast:google-cloud-core-1.4.2rc1

Conversation

@tswast

Copy link
Copy Markdown
Contributor

google-cloud-core version 1.4.2 populates prettyPrint=false by
default. Update the connection tests to expect a value for
prettyPrint.

This PR also serves to test that the changes in googleapis/python-cloud-core#28 do not break this library.

`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
@tswasttswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 22, 2020
@tswast
tswast requested a review from a teamSeptember 22, 2020 19:48
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
@product-auto-labelproduct-auto-labelBot added the api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. label Sep 23, 2020
@tswasttswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2020
@tseaver
tseaver merged commit 1a8af71 into googleapis:masterOct 6, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: runtimeconfigIssues related to the googleapis/python-runtimeconfig API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@tseaver