Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

Fix alembic incompatibility with sqlalchemy < 1.3.11 - #270

Closed
elainearbaugh wants to merge 1 commit into
googleapis:mainfrom
elainearbaugh:fix-computed-column-incompatibility
Closed

Fix alembic incompatibility with sqlalchemy < 1.3.11#270
elainearbaugh wants to merge 1 commit into
googleapis:mainfrom
elainearbaugh:fix-computed-column-incompatibility

Conversation

@elainearbaugh

Copy link
Copy Markdown

Also adds a unit test specifically targeting these sqlalchemy versions (this test fails without the fix). Not sure if this is the best way to check for this attribute so lmk if there's a more elegant way to do it

Fixes#269

  • Tests pass
  • [n/a] Appropriate changes to README are included in PR

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Oct 13, 2022

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Oct 13, 2022
@IlyaFaer

Copy link
Copy Markdown

@elainearbaugh, the PR looks okay to me. They only thing needed is for you to sign the CLA agreement:
https://github.com/googleapis/python-spanner-sqlalchemy/blob/main/CONTRIBUTING.md#contributor-license-agreement
Then we can merge it.

@elainearbaugh

Copy link
Copy Markdown
Author

@IlyaFaer thanks! I just got the CLA signed this week, working through the other issues now

@elainearbaugh
elainearbaughforce-pushed the fix-computed-column-incompatibility branch 2 times, most recently from 7aa0711 to 3270d9aCompareNovember 10, 2022 18:06
…nit test specifically targeting
these sqlalchemy versions
@elainearbaugh
elainearbaughforce-pushed the fix-computed-column-incompatibility branch from 3270d9a to f651dc9CompareNovember 10, 2022 18:08
@elainearbaugh

Copy link
Copy Markdown
Author

@IlyaFaer resolved the commit issues as well so if you could allow running workflows and re-review that'd be awesome! Sorry for being slow, it took a while for my org to get the CLA through

@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2022
@elainearbaugh

Copy link
Copy Markdown
Author

I'm not sure what's going on with the Kokoro failure--seems like it hit a "ERROR: Aborting VM command due to timeout of 10800 seconds" (3 hours)? I added some additional testing but it definitely doesn't take 3 hours running locally...I don't think I have the ability to rerun the tests if it's a flake so not sure what my next steps should be here

@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@IlyaFaerIlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2022
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2022
@olavloite

Copy link
Copy Markdown
Contributor

Closing, as this seems to have been implemented through another PR (and this PR is also very old)

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spannerIssues related to the googleapis/python-spanner-sqlalchemy API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

alembic incompatibility with sqlalchemy < 1.3.11 due to computed columns

5 participants

@elainearbaugh@IlyaFaer@olavloite@asthamohta@yoshi-kokoro