Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

test: fix numeric compliance test - #29

Merged
larkee merged 20 commits into
mainfrom
numeric_compliance_test
May 13, 2021
Merged

test: fix numeric compliance test#29
larkee merged 20 commits into
mainfrom
numeric_compliance_test

Conversation

@HemangChothani

@HemangChothaniHemangChothani commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2021
larkee
larkee reviewed Mar 22, 2021
View reviewed changes

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of skipping relating to decimal which I'm concerned about. Would the changes included in #33 be relevant here?

Comment threadtest/test_suite.py Outdated
Comment threadtest/test_suite.py Outdated
@HemangChothani

HemangChothani commented Mar 24, 2021

Copy link
Copy Markdown
ContributorAuthor

All the tests passes once googleapis/python-spanner#290 PR merged.

@skuruppu
skuruppu requested a review from vi3k6i5April 29, 2021 04:54
@vi3k6i5

vi3k6i5 commented May 4, 2021

Copy link
Copy Markdown
Contributor

Tests look good to me. LGTM.

vi3k6i5
vi3k6i5 approved these changes May 4, 2021
View reviewed changes

@vi3k6i5vi3k6i5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes look good to me. Please wait for Skylar's approval before merging.

larkee
larkee reviewed May 7, 2021
View reviewed changes

@larkeelarkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the nit

Comment threadtest/test_suite.py Outdated
larkee
larkee reviewed May 10, 2021
View reviewed changes
Comment threadgoogle/cloud/sqlalchemy_spanner/requirements.py Outdated
Comment threadgoogle/cloud/sqlalchemy_spanner/requirements.py Outdated
@HemangChothani

HemangChothani commented May 11, 2021

Copy link
Copy Markdown
ContributorAuthor

Failed test will be resolved by PR #62

larkee
larkee reviewed May 12, 2021
View reviewed changes
Comment threadtest/test_suite.py Outdated
of 38 and scale of 9.
"""
self._do_test(
Numeric(precision=18, scale=12),

@larkeelarkeeMay 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are overriding a number of tests because Spanner does not support scale>9. But these tests still uses Numeric with scale=12 or scale=14. I think it makes sense to change these Numerics to use scale=9. WDYT?

@larkee
larkee merged commit 06a3844 into mainMay 13, 2021
@IlyaFaer
IlyaFaer deleted the numeric_compliance_test branch November 17, 2021 10:04
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@vi3k6i5vi3k6i5vi3k6i5 approved these changes
@larkeelarkeelarkee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HemangChothani@vi3k6i5@larkee